Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r18607
From: Brian Barrett (brbarret_at_[hidden])
Date: 2008-06-06 12:04:57


Since this is not the first or second time we've had the discussion in
the group, perhaps a comment in the code would be a good idea :).

Brian

On Jun 6, 2008, at 9:58 AM, Jeff Squyres wrote:

> George --
>
> This is not correct. Note the comment that says to see MPI-1.2
> section 3.2.5 page 22 (I think it means MPI-1.1). It says:
>
> "In general, message passing calls do not modify the value of the
> error code field of status variables. This field may be updated only
> by the functions in Section 3.7.5 which return multiple statuses."
>
> So we should not be setting status.MPI_ERROR here; you should check
> the return value from MPI_WAIT to get the error code.
>
>
>
> On Jun 6, 2008, at 11:53 AM, bosilca_at_[hidden] wrote:
>
>> Author: bosilca
>> Date: 2008-06-06 11:53:17 EDT (Fri, 06 Jun 2008)
>> New Revision: 18607
>> URL: https://svn.open-mpi.org/trac/ompi/changeset/18607
>>
>> Log:
>> Update the MPI_ERROR field as well.
>>
>> Text files modified:
>> trunk/ompi/request/req_wait.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> Modified: trunk/ompi/request/req_wait.c
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- trunk/ompi/request/req_wait.c (original)
>> +++ trunk/ompi/request/req_wait.c 2008-06-06 11:53:17 EDT (Fri, 06
>> Jun 2008)
>> @@ -50,6 +50,7 @@
>> /* See MPI-1.2, sec 3.2.5, p.22 */
>> status->MPI_TAG = req->req_status.MPI_TAG;
>> status->MPI_SOURCE = req->req_status.MPI_SOURCE;
>> + status->MPI_ERROR = req->req_status.MPI_ERROR;
>> status->_count = req->req_status._count;
>> status->_cancelled = req->req_status._cancelled;
>> }
>> _______________________________________________
>> svn-full mailing list
>> svn-full_at_[hidden]
>> http://www.open-mpi.org/mailman/listinfo.cgi/svn-full
>
>
> --
> Jeff Squyres
> Cisco Systems
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>

-- 
   Brian Barrett
   Open MPI developer
   http://www.open-mpi.org/