Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |  

This web mail archive is frozen.

This page is part of a frozen web archive of this mailing list.

You can still navigate around this archive, but know that no new mails have been added to it since July of 2016.

Click here to be taken to the new web archives of this list; it includes all the mails that are in this frozen archive plus all new mails that have been sent to the list since it was migrated to the new archives.

Subject: Re: [OMPI devel] openib btl code review
From: Gleb Natapov (glebn_at_[hidden])
Date: 2008-05-15 08:46:30


On Thu, May 15, 2008 at 08:14:29AM -0400, Jeff Squyres wrote:
> Pasha tells me he'll be able to review the patch next week, so I'll
> wait to commit until then. I added the patch to the ticket, just so
> that it doesn't get lost.
>
> Any other reviewers would be welcome... :-)
I'll look at it next week too.

> > The attached patch does the following (Jon wrote part of this, too):
> >
> > - some random style cleanup
> > - fix a few minor memory leaks
> > - adapt _ini.c to accept the "receive_queues" field in the file
> > - move 90% of _setup_qps() from _ini.c to _component.c
> > - move what was left of _setup_qps() into the main
> > _register_mca_params() function
> > - adapt init_one_hca() to detect conflicting receive_queues values
> > from the INI file
> > - after the _component.c loop calling init_one_hca():
> > - call setup_qps() to parse the final receive_queues string value
> > - traverse all resulting btls and initialize their HCAs (if they
> > weren't already): setup some lists and call prepare_hca_for_use()
> >
It is better to have separate patch (and commit) for each of these items.
Doing review and dialing with bugs is much easier this way.

--
			Gleb.