Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] RMAPS rank_file component patch and modifications for review
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2008-03-31 07:57:55


Sorry, I missed this mail.

IIRC, the verbosity level for stream 0 is 0. It probably would not be
good to increase it; many places in the code use output stream 0.

Perhaps you could make a new stream with a different verbosity level
to do what you want...? See the docs in opal/util/output.h.

On Mar 27, 2008, at 8:12 AM, Lenny Verkhovsky wrote:
> NO, just tried to see some printouts during the run,
> I use in the code
>
> opal_output_verbose(0, 0,"LNY100 opal_paffinity_base_slot_list_set
> ver=%d ",0);
> opal_output_verbose(1, 0,"LNY101 opal_paffinity_base_slot_list_set
> ver=%d ",1);
> OPAL_OUTPUT_VERBOSE((1, 0,"VERBOSE LNY102
> opal_paffinity_base_slot_list_set ver=%d ",1));
> but all I see is the first line ( since I put level 0)
> I suppose that to see the second line I must configure with --enable-
> debug, but this is not working for me either.
>
>
>
> On Thu, Mar 27, 2008 at 2:02 PM, Jeff Squyres <jsquyres_at_[hidden]>
> wrote:
> Are you using BTL_OUTPUT or something else from btl_base_error.h?
>
>
> On Mar 27, 2008, at 7:49 AM, Lenny Verkhovsky wrote:
> > Hi,
> > thanks for the comments. I will definetly implement all of them and
> > commit the code as soon as I finished.
> >
> > Also I experience few problems with using opal_verbose_output,
> > either there is a bugs or I am doing something wrong.
> >
> >
> > /home/USERS/lenny/OMPI_ORTE_DEBUG/bin/mpirun -mca mca_verbose 0 -mca
> > paffinity_base_verbose 1 --byslot -np 2 -hostfile hostfile -mca
> > btl_openib_max_lmc 1 -mca opal_paffinity_alone 1 -mca
> > btl_openib_verbose 1 /home/USERS/lenny/TESTS/ORTE/mpi_p01_debug -
> t lt
> >
> >
> > /home/USERS/lenny/TESTS/ORTE/mpi_p01_debug: symbol lookup error: /
> > home/USERS/lenny/OMPI_ORTE_DEBUG//lib/openmpi/mca_btl_openib.so:
> > undefined symbol: mca_btl_base_out
> > /home/USERS/lenny/TESTS/ORTE/mpi_p01_debug: symbol lookup error: /
> > home/USERS/lenny/OMPI_ORTE_DEBUG//lib/openmpi/mca_btl_openib.so:
> > undefined symbol: mca_btl_base_out
> >
> --------------------------------------------------------------------------
> > mpirun has exited due to process rank 1 with PID 5896 on
> > node witch17 exiting without calling "finalize". This may
> > have caused other processes in the application to be
> > terminated by signals sent by mpirun (as reported here).
> >
> >
> > On Wed, Mar 26, 2008 at 2:50 PM, Ralph H Castain <rhc_at_[hidden]>
> wrote:
> > I would tend to echo Tim's suggestions. I note that you do lookup
> > that opal
> > mca param in orte as well. I know you sent me a note about that off-
> > list - I
> > apologize for not getting to it yet, but was swamped yesterday.
> >
> > I think the solution suggested in #1 below is the right approach.
> > Looking up
> > opal params in orte or ompi is probably not a good idea. We have had
> > problems in the past where params were looked up in multiple
> places as
> > people -do- sometimes change the names (ahem...).
> >
> > Also, I would suggest using the macro version of verbose
> > OPAL_OUTPUT_VERBOSE
> > so that it compiles out for non-debug builds - up to you. Many of us
> > use it
> > as we don't need the output from optimized builds.
> >
> > Other than that, I think this looks fine. I do truly appreciate the
> > cleanup
> > of ompi_mpi_init.
> >
> > Ralph
> >
> >
> >
> > On 3/26/08 6:09 AM, "Tim Prins" <tprins_at_[hidden]> wrote:
> >
> > > Hi Lenny,
> > >
> > > This looks good. But I have a couple of suggestions (which others
> > may
> > > disagree with):
> > >
> > > 1. You register an opal mca parameter, but look it up in ompi,
> > then call
> > > a opal function with the result. What if you had a function
> > > opal_paffinity_base_set_slots(long rank) (or some other name, I
> > don't
> > > care) which looked up the mca parameter and then setup the slots
> > as you
> > > are doing if it is fount. This would make things a bit cleaner
> IMHO.
> > >
> > > 2. the functions in the paffinety base should be prefixed with
> > > 'opal_paffinity_base_'
> > >
> > > 3. Why was the ompi_debug_flag added? It is not used anywhere.
> > >
> > > 4. You probably do not need to add the opal debug flag. There is
> > already
> > > a 'paffinity_base_verbose' flag which should suit your purposes
> > fine. So
> > > you should just be able to replace all of the conditional output
> > > statements in paffinity with something like
> > > opal_output_verbose(10, opal_paffinity_base_output, ...),
> > > where 10 is the verbosity level number.
> > >
> > > Tim
> > >
> > >
> > > Lenny Verkhovsky wrote:
> > >>
> > >>
> > >> Hi, all
> > >>
> > >> Attached patch for modified Rank_File RMAPS component.
> > >>
> > >>
> > >>
> > >> 1. introduced new general purpose debug flags
> > >>
> > >> mpi_debug
> > >>
> > >> opal_debug
> > >>
> > >>
> > >>
> > >> 2. introduced new mca parameter opal_paffinity_slot_list
> > >>
> > >> 3. ompi_mpi_init cleaned from opal paffinity functions
> > >>
> > >> 4. opal paffinity functions moved to new file
> > >> opal/mca/paffinity/base/paffinity_base_service.c
> > >>
> > >> 5. rank_file component files were renamed according to prefix
> > policy
> > >>
> > >> 6. global variables renamed as well.
> > >>
> > >> 7. few bug fixes that were brought during previous
> discussions.
> > >>
> > >> 8. If user defines opal_paffinity_alone and
> > rmaps_rank_file_path or
> > >> opal_paffinity_slot_list,
> > >>
> > >> then he gets a Warning that only opal_paffinity_alone will be
> used.
> > >>
> > >>
> > >>
> > >> .
> > >>
> > >> Best Regards,
> > >>
> > >> Lenny.
> > >>
> > >>
> > >>
> > >>
> > >>
> >
> ------------------------------------------------------------------------
> > >>
> > >> _______________________________________________
> > >> devel mailing list
> > >> devel_at_[hidden]
> > >> http://www.open-mpi.org/mailman/listinfo.cgi/devel
> > >
> > > _______________________________________________
> > > devel mailing list
> > > devel_at_[hidden]
> > > http://www.open-mpi.org/mailman/listinfo.cgi/devel
> >
> >
> > _______________________________________________
> > devel mailing list
> > devel_at_[hidden]
> > http://www.open-mpi.org/mailman/listinfo.cgi/devel
> >
> > _______________________________________________
> > devel mailing list
> > devel_at_[hidden]
> > http://www.open-mpi.org/mailman/listinfo.cgi/devel
>
>
> --
> Jeff Squyres
> Cisco Systems
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

-- 
Jeff Squyres
Cisco Systems