Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] RMAPS rank_file component patch and modifications for review
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2008-03-27 07:37:33


A few more comments on top of what Tim / Ralph said:

- opal_paffinity MCA params should be defined and registered in the
opal paffinity base (in the base open function so that ompi_info can
still see them), not opal/runtime/opal_params.c.

- I don't have a problem with setting the paffinity slot list from
ompi_mpi_init, but we should probably make the corresponding MCA
parameter be an "mpi_*" name; because this is functionality that is
being exported through the MPI layer. Additionally, the name
"mpi_<whatever>" will make more sense to users; they don't know
anything about opal/orte -- "mpi_<whatever>" resonates with running
their MPI job.

- I don't think we can delete the MCA param ompi_paffinity_alone; it
exists in the v1.2 series and has historical precedent.

- Note that symbols that are static don't have to abide by the prefix
rule. I'm not saying you need to change anything -- you don't -- I
just notice that you made some symbols both static and use the prefix
rule. That's fine, but if you want to use shorter symbol names for
static symbols, that's fine too.

On Mar 26, 2008, at 6:01 AM, Lenny Verkhovsky wrote:
>
> Hi, all
> Attached patch for modified Rank_File RMAPS component.
>
> 1. introduced new general purpose debug flags
> mpi_debug
> opal_debug
>
> 2. introduced new mca parameter opal_paffinity_slot_list
> 3. ompi_mpi_init cleaned from opal paffinity functions
> 4. opal paffinity functions moved to new file opal/mca/paffinity/
> base/paffinity_base_service.c
> 5. rank_file component files were renamed according to prefix
> policy
> 6. global variables renamed as well.
> 7. few bug fixes that were brought during previous discussions.
> 8. If user defines opal_paffinity_alone and rmaps_rank_file_path
> or opal_paffinity_slot_list,
> then he gets a Warning that only opal_paffinity_alone will be used.
>
> .
> Best Regards,
> Lenny.
>
> <rank_file.patch>

-- 
Jeff Squyres
Cisco Systems