Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: [OMPI devel] use of AC_CACHE_CHECK in otf
From: Ralf Wildenhues (Ralf.Wildenhues_at_[hidden])
Date: 2008-03-06 16:23:41


In ompi/contrib/vt/vt/extlib/otf/acinclude.m4, in the macros WITH_DEBUG
and WITH_VERBOSE, dubious constructs such as

    AC_CACHE_CHECK([debug],
        [debug],
        [debug=])

are used. These have the following problems:

* Cache variables need to match *_cv_* in order to actually be saved
(where the bit before _cv_ is preferably a package or author prefix,
for namespace cleanliness; see
<http://www.gnu.org/software/autoconf/manual/html_node/Cache-Variable-Names.html>.
The next Autoconf version will warn about this.

* There is little need to cache information that the user provided on
the configure command line. If configure is rerun by './config.status
--recheck', it remembers the original configure command line. Only if
the user manually reruns configure (and keeps config.cache) does this
make a difference.

So I suggest you remove those two instances of AC_CACHE_CHECK usage,
or forward this information to the author of oft.

Thanks,
Ralf