Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r17681
From: Rainer Keller (keller_at_[hidden])
Date: 2008-03-03 12:21:50


Ralph,
On Monday 03 March 2008 17:06, rhc_at_[hidden] wrote:
> Author: rhc
> Date: 2008-03-03 11:06:47 EST (Mon, 03 Mar 2008)
> New Revision: 17681
> URL: https://svn.open-mpi.org/trac/ompi/changeset/17681
>
> Log:
> Cleanup an attribute warning - not sure which one to set or where it should
> go, so I'll leave that to someone more familiar with "attributes".
>
> Ensure some debugging is only enabled when have_debug is set.

> Modified: trunk/orte/mca/errmgr/errmgr.h
> ===========================================================================
>=== --- trunk/orte/mca/errmgr/errmgr.h (original)
> +++ trunk/orte/mca/errmgr/errmgr.h 2008-03-03 11:06:47 EST (Mon, 03 Mar
> 2008) @@ -132,7 +132,7 @@
> * itself, and then exit - it takes no other actions. The intent here is
> to provide * a last-ditch exit procedure that attempts to clean up a
> little. */
> -typedef void (*orte_errmgr_base_module_abort_fn_t)(int error_code, char
> *fmt, ...) __opal_attribute_format__(__printf__, 2, 3);
> +typedef void (*orte_errmgr_base_module_abort_fn_t)(int error_code, char
> *fmt, ...);

What was the warning requiring You to get rid of the attribute?

The attribute should help find errors in the callers to
orte_errmgr_base_abort...

Maybe the help on
  https://svn.open-mpi.org/trac/ompi/wiki/CompilerAttributes
could be improved?

Thanks,
Rainer

-- 
----------------------------------------------------------------
Dipl.-Inf. Rainer Keller   http://www.hlrs.de/people/keller
 HLRS                          Tel: ++49 (0)711-685 6 5858
 Nobelstrasse 19                  Fax: ++49 (0)711-685 6 5832
 70550 Stuttgart                    email: keller_at_[hidden]     
 Germany                             AIM/Skype:rusraink