Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] configure patch
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2008-01-24 19:00:23


On Jan 19, 2008, at 3:38 AM, Ralf Wildenhues wrote:

> This patch will not work with Solaris sh. Please consider using this
> instead, it should avoid the issues with both shells. (Untested.)

Ralf -- the original patch changed both ompi_get_version.m4 and
ompi_get_version.sh; your patch only changes the m4.

Is there equivalent magic for the sh file as well?

>
> Cheers,
> Ralf
>
>
> Index: config/ompi_get_version.m4
> ===================================================================
> --- config/ompi_get_version.m4 (Revision 17165)
> +++ config/ompi_get_version.m4 (Arbeitskopie)
> @@ -41,7 +41,7 @@
>
> dnl quote eval to suppress macro expansion with non-GNU m4
> if test -f "$1"; then
> - [eval] "`sed -n \"\
> + ompi_vers=`sed -n "
> t clear
> : clear
> s/^major/$2_MAJOR_VERSION/
> @@ -53,7 +53,8 @@
> t print
> b
> : print
> - p\" < \"\$1\"`"
> + p" < "$1"`
> + [eval] "$ompi_vers"
>
> # Only print release version if it isn't 0
> if test $$2_RELEASE_VERSION -ne 0 ; then

-- 
Jeff Squyres
Cisco Systems