Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] configure patch
From: Ralf Wildenhues (Ralf.Wildenhues_at_[hidden])
Date: 2008-01-19 03:38:39


* Jeff Squyres wrote on Sat, Jan 19, 2008 at 02:03:02AM CET:
> On Jan 8, 2008, at 6:53 PM, Elan Ruusamäe wrote:
> >
> > please consider applying this patch
> > http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SOURCES/openmpi-ksh.patch
> >
> > fixes build process when /bin/sh is not bash (for example pdksh)

> This patch seems to work for me on Linux.
>
> Sun -- can you test this with the Solaris sh?

This patch will not work with Solaris sh. Please consider using this
instead, it should avoid the issues with both shells. (Untested.)

Cheers,
Ralf

Index: config/ompi_get_version.m4
===================================================================
--- config/ompi_get_version.m4 (Revision 17165)
+++ config/ompi_get_version.m4 (Arbeitskopie)
@@ -41,7 +41,7 @@
 
     dnl quote eval to suppress macro expansion with non-GNU m4
     if test -f "$1"; then
- [eval] "`sed -n \"\
+ ompi_vers=`sed -n "
         t clear
         : clear
         s/^major/$2_MAJOR_VERSION/
@@ -53,7 +53,8 @@
         t print
         b
         : print
- p\" < \"\$1\"`"
+ p" < "$1"`
+ [eval] "$ompi_vers"
 
         # Only print release version if it isn't 0
         if test $$2_RELEASE_VERSION -ne 0 ; then