Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] matching code rewrite in OB1
From: Gleb Natapov (glebn_at_[hidden])
Date: 2007-12-11 11:10:26


On Tue, Dec 11, 2007 at 10:00:08AM -0600, Brian W. Barrett wrote:
> On Tue, 11 Dec 2007, Gleb Natapov wrote:
>
> > I did a rewrite of matching code in OB1. I made it much simpler and 2
> > times smaller (which is good, less code - less bugs). I also got rid
> > of huge macros - very helpful if you need to debug something. There
> > is no performance degradation, actually I even see very small performance
> > improvement. I ran MTT with this patch and the result is the same as on
> > trunk. I would like to commit this to the trunk. The patch is attached
> > for everybody to try.
>
> I don't think we can live without those macros :). Out of curiousity, is
> there any functionality that was removed as a result of this change?
No. The way out of order packets are handled changed a little bit, but
they are handled in correct order.

>
> I'll test on a couple systems over the next couple of days...
>
Thanks!

--
			Gleb.