Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r16723
From: Tim Prins (tprins_at_[hidden])
Date: 2007-11-14 09:44:06


Hi,

The following files bother me about this commit:
     trunk/ompi/mca/btl/sctp/sctp_writev.c
     trunk/ompi/mca/btl/sctp/sctp_writev.h

They bother me for 2 reasons:
1. Their naming does not follow the prefix rule
2. They are LGPL licensed. While I personally like the LGPL, I do not
believe it is compatible with the BSD license that OMPI is distributed
under. I think (though I could be wrong) that these files need to be
removed from the repository and the functionality implemented in some
other way.

Tim

penoff_at_[hidden] wrote:
> Author: penoff
> Date: 2007-11-13 18:39:16 EST (Tue, 13 Nov 2007)
> New Revision: 16723
> URL: https://svn.open-mpi.org/trac/ompi/changeset/16723
>
> Log:
> initial SCTP BTL commit
> Added:
> trunk/ompi/mca/btl/sctp/
> trunk/ompi/mca/btl/sctp/.ompi_ignore
> trunk/ompi/mca/btl/sctp/.ompi_unignore
> trunk/ompi/mca/btl/sctp/Makefile.am
> trunk/ompi/mca/btl/sctp/btl_sctp.c
> trunk/ompi/mca/btl/sctp/btl_sctp.h
> trunk/ompi/mca/btl/sctp/btl_sctp_addr.h
> trunk/ompi/mca/btl/sctp/btl_sctp_component.c
> trunk/ompi/mca/btl/sctp/btl_sctp_component.h
> trunk/ompi/mca/btl/sctp/btl_sctp_endpoint.c
> trunk/ompi/mca/btl/sctp/btl_sctp_endpoint.h
> trunk/ompi/mca/btl/sctp/btl_sctp_frag.c
> trunk/ompi/mca/btl/sctp/btl_sctp_frag.h
> trunk/ompi/mca/btl/sctp/btl_sctp_hdr.h
> trunk/ompi/mca/btl/sctp/btl_sctp_proc.c
> trunk/ompi/mca/btl/sctp/btl_sctp_proc.h
> trunk/ompi/mca/btl/sctp/btl_sctp_recv_handler.c
> trunk/ompi/mca/btl/sctp/btl_sctp_recv_handler.h
> trunk/ompi/mca/btl/sctp/btl_sctp_utils.c
> trunk/ompi/mca/btl/sctp/btl_sctp_utils.h
> trunk/ompi/mca/btl/sctp/configure.m4
> trunk/ompi/mca/btl/sctp/configure.params
> trunk/ompi/mca/btl/sctp/sctp_writev.c
> trunk/ompi/mca/btl/sctp/sctp_writev.h
>
>
> Diff not shown due to size (201438 bytes).
> To see the diff, run the following command:
>
> svn diff -r 16722:16723 --no-diff-deleted
>
> _______________________________________________
> svn mailing list
> svn_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/svn