Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

From: George Bosilca (bosilca_at_[hidden])
Date: 2007-09-25 11:20:53


He's right. By mistake I modified the mpi_interface.h file, when I
knew that it should not be modified. This file is identical for all
MPI implementations that provide parallel debuggers support. It
define the interfaces between us and them ... interfaces that include
functions as well as structures.

The unique_id field was not used in Open MPI, as it didn't seems to
me that the tv guys are using it. Therefore, instead of using the
unique_id field in their interface structure, I use the recv_context
in our own version. However, as I said, the interface should never be
changed, so Pak was right by rolling back this mpi_interface.h file.
I'll commit another change soon, where I get rid of our own internal
cid field in favor of the unique_id.

   Thanks,
     george.

On Sep 25, 2007, at 9:15 AM, Pak Lui wrote:

> Hi Tim,
>
> Tim Mattox wrote:
>> Hmm, why should an external debugger dictate the members
>> of our communicator struct? Does MPICH, etc. have the exact same
>> structure for their comunicators? I doubt it.
>
> Yes, only for mqs_communicator which shares between the DLL and TV. In
> fact, the whole mpi_interface.h should not be touched. Nikolay
> Piskun of
> Totalview Tech confirmed it.
>
>>
>> If George's r16177 change is correct, mqs_taddr_t unique_id is never
>> used or set in OMPI.
>
> Yes, it is not used for now. But George seems to have second thought
> about using this unique_id instead of our own cid to make things
> consistent. We'll stay tuned on what he has to do...
>
>>
>> I'm sure TotalView & DLL already need to adjust what binary interface
>> they expect based on which version of OMPI they are interacting
>> with...
>> what is one more struct difference?
>> If it is very important for this struct to not change, please add
>> a comment
>> to the struct explaining why it shouldn't be changed.
>
> I will, once I've figured out how to modify my existing comment for
> r16200. Just to show you the kind of badness you'll see by taking
> things
> out from the struct should show you a messed up comm name and
> comm_size,
> like this on both Solaris AMD and SPARC. By putting this member
> back to
> the struct, at least it can band aid the problem.
>
> _WORLD
> Comm_size 5571033412557294925
> Comm_rank 4
> Pending receives : none
> Unexpected messages : no information available
> Pending sends : none
>
> _SELF
> Comm_size 5571033412557294925
> Comm_rank 1
> Pending receives : none
> Unexpected messages : no information available
> Pending sends : none
>
> _NULL
> Comm_size 5571033412557294925
> Comm_rank 0
> Pending receives : none
> Unexpected messages : no information available
> Pending sends : none
>
>>
>>
>> On 9/24/07, paklui_at_[hidden] <paklui_at_[hidden]> wrote:
>>> Author: paklui
>>> Date: 2007-09-24 15:02:56 EDT (Mon, 24 Sep 2007)
>>> New Revision: 16200
>>> URL: https://svn.open-mpi.org/trac/ompi/changeset/16200
>>>
>>> Log:
>>> mqs_communicator type should not be changed as it serves as the
>>> interface
>>> between Totalview and DLL.
>>>
>>>
>>> Text files modified:
>>> trunk/ompi/debuggers/mpi_interface.h | 3 ++-
>>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>>
>>> Modified: trunk/ompi/debuggers/mpi_interface.h
>>> ====================================================================
>>> ==========
>>> --- trunk/ompi/debuggers/mpi_interface.h (original)
>>> +++ trunk/ompi/debuggers/mpi_interface.h 2007-09-24
>>> 15:02:56 EDT (Mon, 24 Sep 2007)
>>> @@ -259,7 +259,8 @@
>>> /* A structure to represent a communicator */
>>> typedef struct
>>> {
>>> - mqs_tword_t local_rank; /* The rank of this
>>> process Comm_rank */
>>> + mqs_taddr_t unique_id; /* A unique tag
>>> for the communicator */
>>> + mqs_tword_t local_rank; /* The rank of
>>> this process Comm_rank */
>>> mqs_tword_t size; /* Comm_size */
>>> char name[64]; /* the name if it
>>> has one */
>>> } mqs_communicator;
>>> _______________________________________________
>>> svn-full mailing list
>>> svn-full_at_[hidden]
>>> http://www.open-mpi.org/mailman/listinfo.cgi/svn-full
>>>
>>
>>
>
>
> --
>
>
> - Pak Lui
> pak.lui_at_[hidden]
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel



  • application/pkcs7-signature attachment: smime.p7s