Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

From: Tim Mattox (timattox_at_[hidden])
Date: 2007-09-25 08:23:26


Hmm, why should an external debugger dictate the members
of our communicator struct? Does MPICH, etc. have the exact same
structure for their comunicators? I doubt it.

If George's r16177 change is correct, mqs_taddr_t unique_id is never
used or set in OMPI.

I'm sure TotalView & DLL already need to adjust what binary interface
they expect based on which version of OMPI they are interacting with...
what is one more struct difference?
If it is very important for this struct to not change, please add a comment
to the struct explaining why it shouldn't be changed.

On 9/24/07, paklui_at_[hidden] <paklui_at_[hidden]> wrote:
> Author: paklui
> Date: 2007-09-24 15:02:56 EDT (Mon, 24 Sep 2007)
> New Revision: 16200
> URL: https://svn.open-mpi.org/trac/ompi/changeset/16200
>
> Log:
> mqs_communicator type should not be changed as it serves as the interface
> between Totalview and DLL.
>
>
> Text files modified:
> trunk/ompi/debuggers/mpi_interface.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> Modified: trunk/ompi/debuggers/mpi_interface.h
> ==============================================================================
> --- trunk/ompi/debuggers/mpi_interface.h (original)
> +++ trunk/ompi/debuggers/mpi_interface.h 2007-09-24 15:02:56 EDT (Mon, 24 Sep 2007)
> @@ -259,7 +259,8 @@
> /* A structure to represent a communicator */
> typedef struct
> {
> - mqs_tword_t local_rank; /* The rank of this process Comm_rank */
> + mqs_taddr_t unique_id; /* A unique tag for the communicator */
> + mqs_tword_t local_rank; /* The rank of this process Comm_rank */
> mqs_tword_t size; /* Comm_size */
> char name[64]; /* the name if it has one */
> } mqs_communicator;
> _______________________________________________
> svn-full mailing list
> svn-full_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/svn-full
>

-- 
Tim Mattox, Ph.D. - http://homepage.mac.com/tmattox/
 tmattox_at_[hidden] || timattox_at_[hidden]
    I'm a bright... http://www.the-brights.net/