Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

From: Ralph Castain (rhc_at_[hidden])
Date: 2007-06-06 16:29:55


George

I believe that such non-professional comments do not belong in a code base
that will be distributed to the public. I have removed this one - kindly
refrain from them in the future.

I remind you that the decision to use dynamic memory was made in an ORTE
design meeting here at LANL three years ago which you (among many others)
attended. If you feel that decision should be revisited, then fine - let's
revisit it.

Meantime, I appreciate catching the necessary free - let's do it without the
negative wisecracks.

Thanks
Ralph

On 6/6/07 2:17 PM, "bosilca_at_[hidden]" <bosilca_at_[hidden]> wrote:

> Author: bosilca
> Date: 2007-06-06 16:17:27 EDT (Wed, 06 Jun 2007)
> New Revision: 14923
> URL: https://svn.open-mpi.org/trac/ompi/changeset/14923
>
> Log:
> Don't forget to free the temporary buffer.
>
> Text files modified:
> trunk/orte/mca/gpr/replica/functional_layer/gpr_replica_put_get_fn.c |
> 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> Modified: trunk/orte/mca/gpr/replica/functional_layer/gpr_replica_put_get_fn.c
> ==============================================================================
> ---
>
trunk/orte/mca/gpr/replica/functional_layer/gpr_replica_put_get_fn.c (original>
)
> +++
> trunk/orte/mca/gpr/replica/functional_layer/gpr_replica_put_get_fn.c 2007-06-0
> 6 16:17:27 EDT (Wed, 06 Jun 2007)
> @@ -139,6 +139,7 @@
> for (i=0; i < num_tokens; i++) {
> orte_gpr_replica_dict_reverse_lookup(&tmp, seg, token_itags[i]);
> opal_output(0, "\t%s", tmp);
> + free(tmp); /* We all enjoy allocating and releasing memory all
> over the code isn't it ? */
> }
> }
>
> _______________________________________________
> svn mailing list
> svn_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/svn