Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

From: Ralph Castain (rhc_at_[hidden])
Date: 2007-05-29 14:00:56


My apologies - I reviewed the opal code and see that it wasn't what I
remembered. The objection here is that strncmp returns an int, not a
pointer, and hence the NULL is bothering the compiler.

I'll submit the fix

Thanks
Ralph

On 5/29/07 11:56 AM, "Ralph Castain" <rhc_at_[hidden]> wrote:

> Hmmm...well, this operation
>
> if ( NULL == strncmp(appctx->app, OPAL_PATH_SEP, 1 )) {
>
> is not a legal one since OPAL_PATH_SEP is a character and not a
> NULL-terminated string and thus generates the following warning:
>
> totalview.c: In function 'orte_totalview_init_after_spawn':
> totalview.c:412: warning: comparison between pointer and integer
>
> Could you modify it?
>
> Thanks
> Ralph
>
>
>
> On 5/29/07 11:39 AM, "Anya_at_[hidden]" <Anya_at_[hidden]> wrote:
>
>> Author: Anya
>> Date: 2007-05-29 13:39:11 EDT (Tue, 29 May 2007)
>> New Revision: 14789
>> URL: https://svn.open-mpi.org/trac/ompi/changeset/14789
>>
>> Log:
>> Ref Trac #1032; added suport for full path launching with TotalView
>> Text files modified:
>> trunk/orte/tools/orterun/totalview.c | 11 +++++++++--
>> 1 files changed, 9 insertions(+), 2 deletions(-)
>>
>> Modified: trunk/orte/tools/orterun/totalview.c
>>
=============================================================================>>
=
>> --- trunk/orte/tools/orterun/totalview.c (original)
>> +++ trunk/orte/tools/orterun/totalview.c 2007-05-29 13:39:11 EDT (Tue, 29 May
>> 2007)
>> @@ -10,6 +10,7 @@
>> * University of Stuttgart. All rights reserved.
>> * Copyright (c) 2004-2005 The Regents of the University of California.
>> * All rights reserved.
>> + * Copyright (c) 2007 Sun Microsystems, Inc. All rights reserved.
>> * $COPYRIGHT$
>> *
>> * Additional copyrights may follow
>> @@ -408,8 +409,14 @@
>> appctx = map->apps[proc->app_idx];
>>
>> MPIR_proctable[i].host_name = strdup(node->nodename);
>> - MPIR_proctable[i].executable_name =
>> - opal_os_path( false, appctx->cwd, appctx->app, NULL );
>> + if ( NULL == strncmp(appctx->app, OPAL_PATH_SEP, 1 )) {
>> + MPIR_proctable[i].executable_name =
>> + opal_os_path( false, appctx->app, NULL );
>> + }
>> + else {
>> + MPIR_proctable[i].executable_name =
>> + opal_os_path( true, appctx->app, NULL );
>> + }
>> MPIR_proctable[i].pid = proc->pid;
>> i++;
>> }
>> _______________________________________________
>> svn mailing list
>> svn_at_[hidden]
>> http://www.open-mpi.org/mailman/listinfo.cgi/svn
>
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel