Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

From: George Bosilca (bosilca_at_[hidden])
Date: 2006-10-11 14:28:58


I'm usually not in favor of such commits. They are very development
specific, and to be honest very user specific. I use valgrind on a
regular basis, but that's not a reason to commit my changes into the
trunk. However, I think it can be interesting to allow us to prepend
something to the command line.

If you ask me how I use valgrind I will tell you that I spawn an
xterm with valgrind inside (and let vagrind start gdb for me when it
detect some memory problems). If we want to have a generic solution
that will work for everybody let's create a MCA parameter which
contain a string that will be prepended to all orted command lines.
So instead of starting "orted $args" we will start "$orte_prepend
orted $args". That way everybody can configure the spawning process
exactly as they want.

   Thanks,
     george.

On Oct 11, 2006, at 1:48 PM, rhc_at_[hidden] wrote:

> Author: rhc
> Date: 2006-10-11 13:48:41 EDT (Wed, 11 Oct 2006)
> New Revision: 12092
>
> Modified:
> trunk/orte/mca/pls/rsh/pls_rsh_component.c
>
> Log:
> Add the proper valgrind params
>
>
> Modified: trunk/orte/mca/pls/rsh/pls_rsh_component.c
> ======================================================================
> ========
> --- trunk/orte/mca/pls/rsh/pls_rsh_component.c (original)
> +++ trunk/orte/mca/pls/rsh/pls_rsh_component.c 2006-10-11 13:48:41
> EDT (Wed, 11 Oct 2006)
> @@ -110,6 +110,7 @@
> {
> int tmp;
> char *ctmp;
> + char *valgrind = "valgrind --verbose --log-file=debug.out --
> num-callers=100 --tool=memcheck --trace-children=no --leak-
> check=full --show-reachable=yes";
> mca_base_component_t *c =
> &mca_pls_rsh_component.super.pls_version;
>
> /* initialize globals */
> @@ -158,7 +159,7 @@
> "Whether or not to launch the
> orteds under valgrind (Linux *only*)",
> false, false, (int)false, &tmp);
> if (tmp) {
> - asprintf(&ctmp, "valgrind %s", mca_pls_rsh_component.orted);
> + asprintf(&ctmp, "%s %s", valgrind,
> mca_pls_rsh_component.orted);
> free(mca_pls_rsh_component.orted);
> mca_pls_rsh_component.orted = ctmp;
> }
> _______________________________________________
> svn mailing list
> svn_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/svn