Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

From: Adrian Knoth (adi_at_[hidden])
Date: 2006-08-21 03:57:36


On Sat, Aug 19, 2006 at 11:07:26PM +0200, Adrian Knoth wrote:

> Hi,

Hi!
 
> Do you agree with a resulting URL like tcp://[2001:6f8::1]:port or
> do you think it should be tcp6://?

I've changed this to tcp6://, because orte/mca/oob/tcp/oob_tcp.c
contains the following lines:

    /* setup the IP address for storage */
    tmp = mca_oob.oob_get_addr();
    tmp2 = strrchr(tmp, '/') + 1;
    tmp3 = strrchr(tmp, ':');
    if(NULL == tmp2 || NULL == tmp3) {

The old way (tcp://[IPv6]) would require code to remove
'[' and ']' iff af_family == AF_INET6.

tcp6:// does not need any special treatment.

> IPv6 interface discovery (talking about opal/util/if.c again)
> needs special treatment on some systems. Right now, I have
> -DLINUX_IPV6 and I'd probably need to catch more (at least
> HPUX defines SIOCGLIFADDR which is also present on OpenBSD).
>
> If I'd have something like -DLINUX, I wouldn't need to
> introduce more defines (like -DLINUX_IPV6 oder -DBSD_IPV6).

I'm now using the compiler defines:

#ifdef __linux__
#endif

-- 
mail: adi_at_[hidden]  	http://adi.thur.de	PGP: v2-key via keyserver
Fighting for peace is like fucking for virginity!