Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

From: Galen M. Shipman (gshipman_at_[hidden])
Date: 2005-09-21 13:06:18


Gleb,

>
> Gleb Natapov wrote:
>
>> Hello Galen,
>>
>> Finally I've got some time to look through the new code.
>> I have couple of notes. In pml_ob1_rdma.c you try to merge
>> registrations in the number of places. The code looks like this:
>> btl_mpool->mpool_deregister(btl_mpool, reg);
>> btl_mpool->mpool_register(btl_mpool,
>> new_base,
>> new_len,
>> MCA_MPOOL_FLAGS_CACHE,
>> &reg);
>> How do you know reg is not in use? You can't deregister it if
>> somebody
>> is using the registration!
>>
>
> Good catch... this should check the reference count and
> only deregister when the reference count actually goes to zero...
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>

Yes, this was a good catch.. This was causing all sorts of fun for us!
Thanks,

Galen