Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

From: Ralf Wildenhues (Ralf.Wildenhues_at_[hidden])
Date: 2005-08-31 06:46:59


Hi Jeff,

* Jeff Squyres wrote on Wed, Aug 31, 2005 at 12:58:05PM CEST:
> On Aug 31, 2005, at 2:48 AM, Ralf Wildenhues wrote:
>
> > Please apply the first patch (or a similar solution) to include
> > ltdl.h directly. This is both how it's documented and how
> > it will work with Libtool 1.5.x and 2.x: the latter has other
> > included files, which live one directory level further down
>
> Done, thanks.

I missed another instance of this (exposed by "make check"), sorry.
See below.

> > Below is another tiny patch to please "make distcheck"
> > (on my machine all there is left to make it pass is one failing test
> > and the tarballs not being removed properly; the latter will be fixed
> > by computing the VERSION argument to AC_INIT properly.)
>
> Brian's still working on this. Given that our goal is to start making
> release candidates in the near future, we opted to not bring over any
> of that stuff to the trunk until after we branch for 1.0.

Oh, that's fine. I just thought I'd let you know about the reason.

Cheers,
Ralf

        * test/support/components.c, test/support/Makefile.am:
        Adjust include paths for ltdl.h.

Index: test/support/components.c
===================================================================
--- test/support/components.c (revision 7107)
+++ test/support/components.c (working copy)
@@ -20,7 +20,7 @@
 
 #include "ompi/include/constants.h"
 #include "opal/include/constants.h"
-#include "libltdl/ltdl.h"
+#include "ltdl.h"
 #include "components.h"
 #include "mca/mca.h"
 
Index: test/support/Makefile.am
===================================================================
--- test/support/Makefile.am (revision 7107)
+++ test/support/Makefile.am (working copy)
@@ -16,7 +16,8 @@
 
 AM_CPPFLAGS = \
         -DBUILDDIR=\"$(OMPI_TOP_BUILDDIR)\" \
- -DSRCDIR=\"$(OMPI_TOP_SRCDIR)\"
+ -DSRCDIR=\"$(OMPI_TOP_SRCDIR)\" \
+ -I$(srcdir)/opal/libltdl
 
 #
 # This should be libsupport.a, not libsupport.la. Automake doesn't