Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

From: Galen Shipman (gshipman_at_[hidden])
Date: 2005-08-12 09:19:30


Hey Gleb,

Sorry for the delay.. we have been doing a bit of reworking of the
pml/btl so that the btl's can be shared outside of just the pml
(collectives, etc).

I have added the bug fix (old_reg). Will look at the assumption of
non-null registration next.

Thanks (and keep them coming ;-) ,

Galen

On Aug 11, 2005, at 8:27 AM, Gleb Natapov wrote:

> Hello,
>
> There are couple of bugs/typos in openib mpool. First one is fixed
> by included patch. Second one is in function mca_mpool_openib_free().
> This function assumes that registration is never NULL, but there are
> callers that think different (ompi/class/ompi_fifo.h,
> ompi/class/ompi_circular_buffer_fifo.h)
>
>
> Index: ompi/mca/mpool/openib/mpool_openib_module.c
> ===================================================================
> --- ompi/mca/mpool/openib/mpool_openib_module.c (revision 6806)
> +++ ompi/mca/mpool/openib/mpool_openib_module.c (working copy)
> @@ -127,7 +127,7 @@
> mca_mpool_base_registration_t* old_reg = *registration;
> void* new_mem = mpool->mpool_alloc(mpool, size, 0, registration);
> memcpy(new_mem, addr, old_reg->bound - old_reg->base);
> - mpool->mpool_free(mpool, addr, &old_reg);
> + mpool->mpool_free(mpool, addr, old_reg);
> return new_mem;
>
> }
> --
> Gleb.
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel