Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

From: Gleb Natapov (glebn_at_[hidden])
Date: 2005-08-11 09:27:14


Hello,

 There are couple of bugs/typos in openib mpool. First one is fixed
by included patch. Second one is in function mca_mpool_openib_free().
This function assumes that registration is never NULL, but there are
callers that think different (ompi/class/ompi_fifo.h,
ompi/class/ompi_circular_buffer_fifo.h)

Index: ompi/mca/mpool/openib/mpool_openib_module.c
===================================================================
--- ompi/mca/mpool/openib/mpool_openib_module.c (revision 6806)
+++ ompi/mca/mpool/openib/mpool_openib_module.c (working copy)
@@ -127,7 +127,7 @@
     mca_mpool_base_registration_t* old_reg = *registration;
     void* new_mem = mpool->mpool_alloc(mpool, size, 0, registration);
     memcpy(new_mem, addr, old_reg->bound - old_reg->base);
- mpool->mpool_free(mpool, addr, &old_reg);
+ mpool->mpool_free(mpool, addr, old_reg);
     return new_mem;
 
 }

--
			Gleb.