Subject: Re: [MTT users] [MTT bugs] [MTT] #212:Genericnetworklockingserver *REVIEW NEEDED*
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2010-03-08 11:46:02
Ok. The rest of it looked ok to me.
On Mar 8, 2010, at 8:41 AM, Ethan Mallove wrote:
> I can do the below stuff in a seperate commit.
>
> -Ethan
>
> On Fri, Mar/05/2010 09:26:21PM, Jeff Squyres wrote:
> > On Mar 5, 2010, at 2:05 PM, Ethan Mallove wrote:
> >
> > > The check is there now. Ready for review.
> >
> > Did you mean to include these parts?
> >
> > --- lib/MTT/Messages.pm Mon Nov 09 14:38:09 2009 -0500
> > +++ lib/MTT/Messages.pm Fri Mar 05 14:02:39 2010 -0500
> > @@ -174,7 +174,7 @@
> > $lev = 0 if (! defined($lev));
> > my @called = caller($lev);
> >
> > - my $s = wrap("", " ", (join(":", map
> { &_relative_path($_) } @called[1..2]), @_));
> > + my $s = (join(":", map { &_relative_path($_) }
> @called[1..2]), @_);
> > print $s;
> > print $LOGFILE $s
> > if (defined($LOGFILE));
> >
> > --- client/mtt Mon Nov 09 14:38:09 2009 -0500
> > +++ client/mtt Fri Mar 05 14:02:39 2010 -0500
> > @@ -498,6 +498,15 @@
> > # execute on_start callback if exists
> > _do_step($ini, "mtt", "before_mtt_start_exec");
> >
> > + # Process setenv, unsetenv, prepend_path, and append_path
> > +
> > + my $config;
> > + $config->{setenv} = Value($ini, "mtt", "setenv");
> > + $config->{unsetenv} = Value($ini, "mtt", "unsetenv");
> > + $config->{prepend_path} = Value($ini, "mtt", "prepend_path");
> > + $config->{append_path} = Value($ini, "mtt", "append_path");
> > + my @save_env;
> > + ProcessEnvKeys($config, \@save_env);
> >
> > # Set the logfile, if specified
> >
> > --- lib/MTT/Defaults.pm Mon Nov 09 14:38:09 2009 -0500
> > +++ lib/MTT/Defaults.pm Fri Mar 05 14:02:39 2010 -0500
> > @@ -42,7 +42,7 @@
> >
> > known_compiler_names => [ "gnu", "pgi", "ibm", "intel",
> "kai", "absoft",
> > "pathscale", "sun", "microsoft",
> "none", "unknown" ],
> > - known_resource_manager_names => [ "slurm", "tm",
> "loadleveler", "n1ge",
> > + known_resource_manager_names => [ "slurm", "tm",
> "loadleveler", "sge",
> > "alps", "none", "unknown" ],
> > known_network_names => [ "tcp", "udp", "ethernet", "gm",
> "mx", "verbs",
> > "udapl", "psm", "elan", "portals",
> "shmem",
> >
> >
> > --
> > Jeff Squyres
> > jsquyres_at_[hidden]
> > For corporate legal information go to:
> > http://www.cisco.com/web/about/doing_business/legal/cri/
> >
> >
> > _______________________________________________
> > mtt-users mailing list
> > mtt-users_at_[hidden]
> > http://www.open-mpi.org/mailman/listinfo.cgi/mtt-users
> _______________________________________________
> mtt-users mailing list
> mtt-users_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/mtt-users
>
-- Jeff Squyres jsquyres_at_[hidden] For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/